feat!: Emitting encrypted log by default #2926

benesjan · 2023-10-19T07:57:52Z

Fixes #2912

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
Every change is related to the PR description.
I have linked this pull request to relevant issues (if any exist).

yarn-project/aztec-nr/aztec/src/note/lifecycle.nr

LHerskind

Again, this is less with just this change, but more general things for the libraries and setup.

For this case, I think it is fine, but we need to think more deeply about the other before we end up splitting nodes.

yarn-project/aztec-nr/aztec/src/note/lifecycle.nr

LHerskind

I like this more 👍

yarn-project/aztec-nr/aztec/src/note/lifecycle.nr

yarn-project/aztec-nr/value-note/src/utils.nr

yarn-project/noir-contracts/src/contracts/card_game_contract/src/cards.nr

AztecBot · 2023-10-19T15:37:21Z

Benchmark results

Metrics with a significant change:

l2_block_building_time_in_ms (8): 9,251 (-16%)
l2_block_building_time_in_ms (32): 36,774 (-17%)
l2_block_building_time_in_ms (128): 164,089 (-17%)
l2_block_rollup_simulation_time_in_ms (8): 6,862 (-16%)
l2_block_rollup_simulation_time_in_ms (32): 27,212 (-18%)
l2_block_rollup_simulation_time_in_ms (128): 108,598 (-17%)
l2_block_public_tx_process_time_in_ms (128): 54,649 (-18%)
l2_block_processing_time_in_ms (32): 4,022 (-16%)
note_successful_decrypting_time_in_ms (32): 1,044 (-19%)
note_successful_decrypting_time_in_ms (128): 4,125 (-18%)
note_trial_decrypting_time_in_ms (8): 38.0 (-61%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit eaa3d4e3 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,864	868,280	3,448,064
l1_rollup_execution_gas	841,951	3,595,388	22,203,433
l2_block_processing_time_in_ms	1,069 (-14%)	⚠️ 4,022 (-16%)	16,026 (-14%)
note_successful_decrypting_time_in_ms	336 (-15%)	⚠️ 1,044 (-19%)	⚠️ 4,125 (-18%)
note_trial_decrypting_time_in_ms	⚠️ 38.0 (-61%)	108 (-2%)	138 (-4%)
l2_block_building_time_in_ms	⚠️ 9,251 (-16%)	⚠️ 36,774 (-17%)	⚠️ 164,089 (-17%)
l2_block_rollup_simulation_time_in_ms	⚠️ 6,862 (-16%)	⚠️ 27,212 (-18%)	⚠️ 108,598 (-17%)
l2_block_public_tx_process_time_in_ms	2,345 (-15%)	9,427 (-15%)	⚠️ 54,649 (-18%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	11,326 (-5%)	21,800 (-4%)
note_history_successful_decrypting_time_in_ms	2,348 (-4%)	4,589 (-5%)
note_history_trial_decrypting_time_in_ms	122 (-1%)	183 (-12%)
node_database_size_in_bytes	1,662,562	1,199,527
pxe_database_size_in_bytes	27,188	54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	47.5 (-10%)	61,697	18,841
private-kernel-ordering	23.7 (-8%)	24,233	8,089
base-rollup	854 (-10%)	639,797	811
root-rollup	38.0 (-8%)	4,072	1,097
private-kernel-inner	42.8 (-9%)	81,504	18,841
public-kernel-private-input	49.2 (-9%)	41,455	18,841
public-kernel-non-first-iteration	31.6 (-11%)	41,497	18,841
merge-rollup	0.928 (-14%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,723	27,508

Co-authored-by: Rahul Kothari <[email protected]>

LHerskind

Minor nits. But otherwise great job, feel free to merge it.

docs/docs/dev_docs/contracts/syntax/events.md

yarn-project/aztec-nr/easy-private-state/src/easy_private_state.nr

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.10.0</summary> ## [0.10.0](aztec-packages-v0.9.0...aztec-packages-v0.10.0) (2023-10-24) ### ⚠ BREAKING CHANGES * Emitting encrypted log by default ([#2926](#2926)) ### Features * Added register-account command to cli ([#2980](#2980)) ([0977a90](0977a90)) * **docs:** Fix portals tutorial formatting ([#2929](#2929)) ([ab19b67](ab19b67)) * Emitting encrypted log by default ([#2926](#2926)) ([1ea2d4f](1ea2d4f)), closes [#2912](#2912) * Goblin translator non-native field relation (Goblin Translator part 6) ([#2871](#2871)) ([c4d8d96](c4d8d96)) * Honk profiling by pass, tsan preset ([#2982](#2982)) ([a1592fd](a1592fd)) * Incorporate docs feedback and add "intermediate" level intros to some pages ([#2598](#2598)) ([78f9f52](78f9f52)) * Nuking `Pokeable` contract ([#2939](#2939)) ([583d6fb](583d6fb)) * Protogalaxy Combiner ([#2436](#2436)) ([a60c70d](a60c70d)) * Protogalaxy perturbator! ([#2624](#2624)) ([509dee6](509dee6)) * Refactor pedersen hash standard ([#2592](#2592)) ([3085676](3085676)) * Widget benchmarking ([#2897](#2897)) ([0e927e9](0e927e9)) ### Bug Fixes * Add @jest/types to box deps ([#2903](#2903)) ([db3fa62](db3fa62)) * Add lint rule for focused tests ([#2901](#2901)) ([fd1a1a8](fd1a1a8)) * Avoid tsc OOM by unignoring an old contract artifact ([#2932](#2932)) ([7310600](7310600)) * Bad it.only in tests ([#2900](#2900)) ([a1f3af1](a1f3af1)) * Boxes boostrap dont use ts-node directly and add .prettierignore ([#2890](#2890)) ([a3b1804](a3b1804)) * Confusing "Unknown complete address" error ([#2967](#2967)) ([3a8f54a](3a8f54a)) * Force jest to quit, otherwise CI can rack up to 3hrs of credits per job. ([#2899](#2899)) ([ba2f671](ba2f671)) * Honk sumcheck performance ([#2925](#2925)) ([5fbfe6e](5fbfe6e)) * Pending commitments contract using the wrong number of arguments ([#2959](#2959)) ([655c322](655c322)) * Prettierignore in boxes ([#2902](#2902)) ([8f7a200](8f7a200)) * Randomness in `AddressNote` ([#2965](#2965)) ([4dc49a9](4dc49a9)) * Yarn lock ([#2923](#2923)) ([7042bc6](7042bc6)) ### Miscellaneous * `Private Data Tree` --> `Note Hash Tree` ([#2945](#2945)) ([abaec9c](abaec9c)), closes [#2906](#2906) * Apply hash abstraction over aztec-nr ([#2958](#2958)) ([52f01ae](52f01ae)) * **docs:** Add Singleton and ImmutableSingleton `view_note` methods ([#2934](#2934)) ([c1497f8](c1497f8)) * Fix box frontend styling ([#2919](#2919)) ([7e9e8cc](7e9e8cc)) * Less noisy benchmark reports ([#2916](#2916)) ([0df166c](0df166c)) * Remove unused nix files ([#2933](#2933)) ([3174f84](3174f84)) * Run all e2e tests against sandbox ([#2891](#2891)) ([6c4e26c](6c4e26c)) * Token box copies noir source files from noir-contracts on bootstrap ([#2940](#2940)) ([a467b96](a467b96)) ### Documentation * Fix: update cheat codes to connect to ethRpcUrl ([#2922](#2922)) ([4ffe9be](4ffe9be)) </details> <details><summary>barretenberg.js: 0.10.0</summary> ## [0.10.0](barretenberg.js-v0.9.0...barretenberg.js-v0.10.0) (2023-10-24) ### Features * Refactor pedersen hash standard ([#2592](#2592)) ([3085676](3085676)) </details> <details><summary>barretenberg: 0.10.0</summary> ## [0.10.0](barretenberg-v0.9.0...barretenberg-v0.10.0) (2023-10-24) ### Features * Goblin translator non-native field relation (Goblin Translator part 6) ([#2871](#2871)) ([c4d8d96](c4d8d96)) * Honk profiling by pass, tsan preset ([#2982](#2982)) ([a1592fd](a1592fd)) * Protogalaxy Combiner ([#2436](#2436)) ([a60c70d](a60c70d)) * Protogalaxy perturbator! ([#2624](#2624)) ([509dee6](509dee6)) * Refactor pedersen hash standard ([#2592](#2592)) ([3085676](3085676)) * Widget benchmarking ([#2897](#2897)) ([0e927e9](0e927e9)) ### Bug Fixes * Honk sumcheck performance ([#2925](#2925)) ([5fbfe6e](5fbfe6e)) ### Miscellaneous * Remove unused nix files ([#2933](#2933)) ([3174f84](3174f84)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.10.0</summary> ## [0.10.0](AztecProtocol/aztec-packages@aztec-packages-v0.9.0...aztec-packages-v0.10.0) (2023-10-24) ### ⚠ BREAKING CHANGES * Emitting encrypted log by default ([#2926](AztecProtocol/aztec-packages#2926)) ### Features * Added register-account command to cli ([#2980](AztecProtocol/aztec-packages#2980)) ([0977a90](AztecProtocol/aztec-packages@0977a90)) * **docs:** Fix portals tutorial formatting ([#2929](AztecProtocol/aztec-packages#2929)) ([ab19b67](AztecProtocol/aztec-packages@ab19b67)) * Emitting encrypted log by default ([#2926](AztecProtocol/aztec-packages#2926)) ([1ea2d4f](AztecProtocol/aztec-packages@1ea2d4f)), closes [#2912](AztecProtocol/aztec-packages#2912) * Goblin translator non-native field relation (Goblin Translator part 6) ([#2871](AztecProtocol/aztec-packages#2871)) ([c4d8d96](AztecProtocol/aztec-packages@c4d8d96)) * Honk profiling by pass, tsan preset ([#2982](AztecProtocol/aztec-packages#2982)) ([a1592fd](AztecProtocol/aztec-packages@a1592fd)) * Incorporate docs feedback and add "intermediate" level intros to some pages ([#2598](AztecProtocol/aztec-packages#2598)) ([78f9f52](AztecProtocol/aztec-packages@78f9f52)) * Nuking `Pokeable` contract ([#2939](AztecProtocol/aztec-packages#2939)) ([583d6fb](AztecProtocol/aztec-packages@583d6fb)) * Protogalaxy Combiner ([#2436](AztecProtocol/aztec-packages#2436)) ([a60c70d](AztecProtocol/aztec-packages@a60c70d)) * Protogalaxy perturbator! ([#2624](AztecProtocol/aztec-packages#2624)) ([509dee6](AztecProtocol/aztec-packages@509dee6)) * Refactor pedersen hash standard ([#2592](AztecProtocol/aztec-packages#2592)) ([3085676](AztecProtocol/aztec-packages@3085676)) * Widget benchmarking ([#2897](AztecProtocol/aztec-packages#2897)) ([0e927e9](AztecProtocol/aztec-packages@0e927e9)) ### Bug Fixes * Add @jest/types to box deps ([#2903](AztecProtocol/aztec-packages#2903)) ([db3fa62](AztecProtocol/aztec-packages@db3fa62)) * Add lint rule for focused tests ([#2901](AztecProtocol/aztec-packages#2901)) ([fd1a1a8](AztecProtocol/aztec-packages@fd1a1a8)) * Avoid tsc OOM by unignoring an old contract artifact ([#2932](AztecProtocol/aztec-packages#2932)) ([7310600](AztecProtocol/aztec-packages@7310600)) * Bad it.only in tests ([#2900](AztecProtocol/aztec-packages#2900)) ([a1f3af1](AztecProtocol/aztec-packages@a1f3af1)) * Boxes boostrap dont use ts-node directly and add .prettierignore ([#2890](AztecProtocol/aztec-packages#2890)) ([a3b1804](AztecProtocol/aztec-packages@a3b1804)) * Confusing "Unknown complete address" error ([#2967](AztecProtocol/aztec-packages#2967)) ([3a8f54a](AztecProtocol/aztec-packages@3a8f54a)) * Force jest to quit, otherwise CI can rack up to 3hrs of credits per job. ([#2899](AztecProtocol/aztec-packages#2899)) ([ba2f671](AztecProtocol/aztec-packages@ba2f671)) * Honk sumcheck performance ([#2925](AztecProtocol/aztec-packages#2925)) ([5fbfe6e](AztecProtocol/aztec-packages@5fbfe6e)) * Pending commitments contract using the wrong number of arguments ([#2959](AztecProtocol/aztec-packages#2959)) ([655c322](AztecProtocol/aztec-packages@655c322)) * Prettierignore in boxes ([#2902](AztecProtocol/aztec-packages#2902)) ([8f7a200](AztecProtocol/aztec-packages@8f7a200)) * Randomness in `AddressNote` ([#2965](AztecProtocol/aztec-packages#2965)) ([4dc49a9](AztecProtocol/aztec-packages@4dc49a9)) * Yarn lock ([#2923](AztecProtocol/aztec-packages#2923)) ([7042bc6](AztecProtocol/aztec-packages@7042bc6)) ### Miscellaneous * `Private Data Tree` --> `Note Hash Tree` ([#2945](AztecProtocol/aztec-packages#2945)) ([abaec9c](AztecProtocol/aztec-packages@abaec9c)), closes [#2906](AztecProtocol/aztec-packages#2906) * Apply hash abstraction over aztec-nr ([#2958](AztecProtocol/aztec-packages#2958)) ([52f01ae](AztecProtocol/aztec-packages@52f01ae)) * **docs:** Add Singleton and ImmutableSingleton `view_note` methods ([#2934](AztecProtocol/aztec-packages#2934)) ([c1497f8](AztecProtocol/aztec-packages@c1497f8)) * Fix box frontend styling ([#2919](AztecProtocol/aztec-packages#2919)) ([7e9e8cc](AztecProtocol/aztec-packages@7e9e8cc)) * Less noisy benchmark reports ([#2916](AztecProtocol/aztec-packages#2916)) ([0df166c](AztecProtocol/aztec-packages@0df166c)) * Remove unused nix files ([#2933](AztecProtocol/aztec-packages#2933)) ([3174f84](AztecProtocol/aztec-packages@3174f84)) * Run all e2e tests against sandbox ([#2891](AztecProtocol/aztec-packages#2891)) ([6c4e26c](AztecProtocol/aztec-packages@6c4e26c)) * Token box copies noir source files from noir-contracts on bootstrap ([#2940](AztecProtocol/aztec-packages#2940)) ([a467b96](AztecProtocol/aztec-packages@a467b96)) ### Documentation * Fix: update cheat codes to connect to ethRpcUrl ([#2922](AztecProtocol/aztec-packages#2922)) ([4ffe9be](AztecProtocol/aztec-packages@4ffe9be)) </details> <details><summary>barretenberg.js: 0.10.0</summary> ## [0.10.0](AztecProtocol/aztec-packages@barretenberg.js-v0.9.0...barretenberg.js-v0.10.0) (2023-10-24) ### Features * Refactor pedersen hash standard ([#2592](AztecProtocol/aztec-packages#2592)) ([3085676](AztecProtocol/aztec-packages@3085676)) </details> <details><summary>barretenberg: 0.10.0</summary> ## [0.10.0](AztecProtocol/aztec-packages@barretenberg-v0.9.0...barretenberg-v0.10.0) (2023-10-24) ### Features * Goblin translator non-native field relation (Goblin Translator part 6) ([#2871](AztecProtocol/aztec-packages#2871)) ([c4d8d96](AztecProtocol/aztec-packages@c4d8d96)) * Honk profiling by pass, tsan preset ([#2982](AztecProtocol/aztec-packages#2982)) ([a1592fd](AztecProtocol/aztec-packages@a1592fd)) * Protogalaxy Combiner ([#2436](AztecProtocol/aztec-packages#2436)) ([a60c70d](AztecProtocol/aztec-packages@a60c70d)) * Protogalaxy perturbator! ([#2624](AztecProtocol/aztec-packages#2624)) ([509dee6](AztecProtocol/aztec-packages@509dee6)) * Refactor pedersen hash standard ([#2592](AztecProtocol/aztec-packages#2592)) ([3085676](AztecProtocol/aztec-packages@3085676)) * Widget benchmarking ([#2897](AztecProtocol/aztec-packages#2897)) ([0e927e9](AztecProtocol/aztec-packages@0e927e9)) ### Bug Fixes * Honk sumcheck performance ([#2925](AztecProtocol/aztec-packages#2925)) ([5fbfe6e](AztecProtocol/aztec-packages@5fbfe6e)) ### Miscellaneous * Remove unused nix files ([#2933](AztecProtocol/aztec-packages#2933)) ([3174f84](AztecProtocol/aztec-packages@3174f84)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

benesjan marked this pull request as draft October 19, 2023 07:57

benesjan force-pushed the janb/emitting_log_by_default branch from 4dec60b to eee4be5 Compare October 19, 2023 10:22

benesjan requested a review from LeilaWang October 19, 2023 10:47

rahul-kothari reviewed Oct 19, 2023

View reviewed changes

yarn-project/aztec-nr/aztec/src/note/lifecycle.nr Outdated Show resolved Hide resolved

LHerskind reviewed Oct 19, 2023

View reviewed changes

yarn-project/aztec-nr/aztec/src/note/lifecycle.nr Outdated Show resolved Hide resolved

yarn-project/aztec-nr/aztec/src/note/lifecycle.nr Outdated Show resolved Hide resolved

LHerskind reviewed Oct 19, 2023

View reviewed changes

yarn-project/aztec-nr/aztec/src/note/lifecycle.nr Outdated Show resolved Hide resolved

yarn-project/aztec-nr/value-note/src/utils.nr Show resolved Hide resolved

yarn-project/noir-contracts/src/contracts/card_game_contract/src/cards.nr Show resolved Hide resolved

benesjan force-pushed the janb/emitting_log_by_default branch 2 times, most recently from 2889e12 to b41e1dc Compare October 19, 2023 15:08

benesjan marked this pull request as ready for review October 19, 2023 15:40

benesjan requested a review from LHerskind October 19, 2023 15:40

benesjan and others added 11 commits October 20, 2023 06:35

WIP on cardgame refactor

214ab26

get_owner in NoteInterface

c2f9b2f

Update yarn-project/aztec-nr/aztec/src/note/lifecycle.nr

8ac2f2c

Co-authored-by: Rahul Kothari <[email protected]>

updated cspell

95004d9

refactor

f78a139

cleanup

1680cd7

updated docs_example

1581df6

import cleanup

af7c6df

full refactor

0f10057

docs imports fix

a154066

updated token box

587fc93

benesjan force-pushed the janb/emitting_log_by_default branch from c5af423 to 587fc93 Compare October 20, 2023 06:49

LHerskind approved these changes Oct 20, 2023

View reviewed changes

docs/docs/dev_docs/contracts/syntax/events.md Outdated Show resolved Hide resolved

yarn-project/aztec-nr/easy-private-state/src/easy_private_state.nr Outdated Show resolved Hide resolved

benesjan added 3 commits October 20, 2023 08:56

cleanup

9f6defd

added customizability to cspell - vscode ordered it

a91dd90

docs import cleanup

75ecfd6

benesjan enabled auto-merge (squash) October 20, 2023 09:05

benesjan merged commit 1ea2d4f into master Oct 20, 2023
2 checks passed

benesjan deleted the janb/emitting_log_by_default branch October 20, 2023 09:18

AztecBot mentioned this pull request Oct 20, 2023

chore(master): Release 0.10.0 #2893

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: Emitting encrypted log by default #2926

feat!: Emitting encrypted log by default #2926

benesjan commented Oct 19, 2023

LHerskind left a comment

LHerskind left a comment

AztecBot commented Oct 19, 2023 •

edited

Loading

L2 block published to L1

L2 chain processing

Circuits stats

Miscellaneous

LHerskind left a comment

feat!: Emitting encrypted log by default #2926

feat!: Emitting encrypted log by default #2926

Conversation

benesjan commented Oct 19, 2023

Checklist:

LHerskind left a comment

Choose a reason for hiding this comment

LHerskind left a comment

Choose a reason for hiding this comment

AztecBot commented Oct 19, 2023 • edited Loading

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Miscellaneous

LHerskind left a comment

Choose a reason for hiding this comment

AztecBot commented Oct 19, 2023 •

edited

Loading